Skip to content

Conversation

@kpenfound
Copy link
Contributor

Discussed in person. We'd like to:

  • Make args optional, so if I don't pass args (or call) we can just use the action to install dagger and run dagger call foo in bash steps manually
  • alias call to args so that we can say call: hello instead of args: hello

Signed-off-by: kpenfound <kyle@dagger.io>
Signed-off-by: kpenfound <kyle@dagger.io>
Signed-off-by: kpenfound <kyle@dagger.io>
Signed-off-by: kpenfound <kyle@dagger.io>
Signed-off-by: kpenfound <kyle@dagger.io>
@kpenfound kpenfound requested review from jpadams and levlaz November 11, 2024 05:47
with:
module: github.com/shykes/daggerverse/hello@v0.3.0
call: hello
- name: "Test call (check)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test case is in the version job - just for clarity, either it should be in a different job, or we could rename this job to something else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I can rename it. I didn't realize the workflow was called version, I just saw test.yml

Copy link
Contributor

@jpadams jpadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Agree to add new job

Signed-off-by: kpenfound <kyle@dagger.io>
Signed-off-by: kpenfound <kyle@dagger.io>
@kpenfound kpenfound merged commit e3a863e into dagger:main Nov 11, 2024
@kpenfound kpenfound deleted the optional_call branch November 11, 2024 17:21
@jedevc jedevc mentioned this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants