rdf_parser test: add a test with a different set of triples #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name of this test (which happened to be the one that was failing for me!) was only being printed on failure.
I've just tracked down an issue in raptor where the turtle parser's buffer wasn't being cleared. The test was passing on most platforms - because the condition being checked for was still true even if the parser read the same data again. Add a test that reads a different input (just one triple) through the same parser, in the hope of catching similar problems in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See dajobe/raptor#78.
The rdf_parser test was passing on some platforms, presumably because the turtle parser was just reading the same data again and then terminating - which would still cause it to pass the test as it read the same number of triples. Add an extra set of tests with just a single triple, which should catch this.
Also fix the heading for one of the tests, which was in the wrong place so it was only getting printed on failure.