Restructured CI workflow #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Compilation - SUCCESS! ✅ |
There was a problem hiding this comment.
Pull request overview
This PR restructures the CI workflow to support multiple platforms and migrates from native SIMD intrinsics to the SIMDe library for better cross-platform compatibility. The key motivation is to enable the codebase to compile and run on non-x86 architectures (like ARM) while maintaining performance on x86.
- Replaces native x86 SIMD intrinsics (
_mm*,__m256*) with SIMDe equivalents (simde_mm*,simde__m256*) - Splits the monolithic CI workflow into separate Linux and macOS workflows with dedicated jobs
- Adds build system improvements including conditional unit test building and platform-specific dependency handling
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| regen/shader/includer.h | Adds missing #include <list> for std::list usage |
| regen/compute/threading.h | Migrates CPU_PAUSE macro from native intrinsics to SIMDe |
| regen/compute/simd.h | Major refactor replacing native SIMD types/intrinsics with SIMDe abstractions |
| regen/compute/radix-sort-cpu.h | Updates SIMD intrinsics to use SIMDe functions |
| README.md | Updates CI badges to reflect new workflow structure |
| CMakeLists.txt | Adds BUILD_UNIT_TESTS flag, removes platform guards from -march=native, adds FreeType brotli dependency |
| .github/workflows/ci-macos.yml | New workflow for macOS builds with Homebrew dependencies |
| .github/workflows/ci-linux.yml | Refactored workflow with separate jobs for build, packaging, and documentation |
| .github/actions/setup-linux/action.yml | New reusable action for installing Linux dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restructures the CI workflow to support multiple platforms and migrates from native SIMD intrinsics to the SIMDe library for better cross-platform compatibility. The key motivation is to enable the codebase to compile and run on non-x86 architectures (like ARM) while maintaining performance on x86.
_mm*,__m256*) with SIMDe equivalents (simde_mm*,simde__m256*)