Minor bug fixes #28
Open
Minor bug fixes #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe the current implementation will also train the RSSM model during evaluation, when training=False is passed. I'm not sure if this is the intended behavior but it looks like a bug to me.
…th the string of the passed distribution. Minor bug fix. dist does not exist at that location in the code. Using self._dist would make the code clear if an incorrect distribution is passed.
NotImplementedError on ActionDecoder uses a None variable. Replace wi…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe these are two minor bugs, although if this is the intended behavior I apologize for the unnecessary changes.