Skip to content

fixed #14347 - fixed Clang warnings in C++20 build #8021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
firewave merged 3 commits into from
Jan 14, 2026
+14 −5
Merged

fixed #14347 - fixed Clang warnings in C++20 build #8021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59bacf4
fixed `-Wdeprecated-this-capture` Clang C++20 warnings
firewave Dec 8, 2025
5cf7e7f
added C++20 builds to CI
firewave Dec 29, 2025
1f43ec5
Ci-unixish.yml: exclude macOS build with C++20 for now
firewave Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/CI-unixish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,16 @@ jobs:
strategy:
matrix:
os: [ubuntu-22.04, macos-15]
cxxstd: [14, 17]
cxxstd: [14, 17, 20]
# FIXME: macos-15 fails to compile with C++20
#
# /Users/runner/work/cppcheck/cppcheck/cmake.output/gui/test/projectfile/moc_testprojectfile.cpp:84:1: error: 'constinit' specifier is incompatible with C++ standards before C++20 [-Werror,-Wc++20-compat]
# 84 | Q_CONSTINIT const QMetaObject TestProjectFile::staticMetaObject = { {
# | ^
# /opt/homebrew/opt/qt/lib/QtCore.framework/Headers/qcompilerdetection.h:1409:23: note: expanded from macro 'Q_CONSTINIT'
exclude:
- os: macos-15
cxxstd: 20
fail-fast: false # Prefer quick result

runs-on: ${{ matrix.os }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/CI-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ jobs:
strategy:
matrix:
os: [windows-2022, windows-2025]
cxxstd: [14, 17]
cxxstd: [14, 17, 20]
Copy link
Owner

@danmar danmar Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to continue adding more c++ versions here.. I like that we are compliant..

Copy link
Collaborator Author

@firewave firewave Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++23 is currently blocked by a long-standing Clang bug: https://trac.cppcheck.net/ticket/14353.

fail-fast: false

runs-on: ${{ matrix.os }}
Expand Down
4 changes: 2 additions & 2 deletions gui/resultstree.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -713,15 +713,15 @@ void ResultsTree::contextMenuEvent(QContextMenuEvent * e)
{
auto *action = new QAction(tr("No tag"), tagMenu);
tagMenu->addAction(action);
connect(action, &QAction::triggered, [=]() {
connect(action, &QAction::triggered, [this]() {
tagSelectedItems(QString());
});
}

for (const QString& tagstr : currentProject->getTags()) {
auto *action = new QAction(tagstr, tagMenu);
tagMenu->addAction(action);
connect(action, &QAction::triggered, [=]() {
connect(action, &QAction::triggered, [tagstr, this]() {
tagSelectedItems(tagstr);
});
}
Expand Down
2 changes: 1 addition & 1 deletion lib/pathmatch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ PathMatch::PathMatch(std::vector<std::string> patterns, std::string basepath, Sy

bool PathMatch::match(const std::string &path, Filemode mode) const
{
return std::any_of(mPatterns.cbegin(), mPatterns.cend(), [=] (const std::string &pattern) {
return std::any_of(mPatterns.cbegin(), mPatterns.cend(), [&] (const std::string &pattern) {
return match(pattern, path, mBasepath, mode, mSyntax);
});
}
Expand Down
Loading