Fix Executor WaitFor race condition #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a race condition whereby pending work items are added to the waiting set _after_ they are actually sent on the work item queue. This means in scenarios where the work item is processed very quickly (i.e. a no-op workflow or activity), the work item is attempted to be completed before it is logged. Updates the wait for funcs to add the items to the pending set before sending them on the work item queue. Signed-off-by: joshvanl <me@joshvanl.dev>
famarting
approved these changes
Jan 30, 2026
yaron2
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a race condition whereby pending work items are added to the waiting set after they are actually sent on the work item queue. This means in scenarios where the work item is processed very quickly (i.e. a no-op workflow or activity), the work item is attempted to be completed before it is logged.
Updates the wait for funcs to add the items to the pending set before sending them on the work item queue.