Skip to content

Conversation

@lindner
Copy link

@lindner lindner commented Jan 21, 2026

Summary

  • Adds PATCH to the HttpMethods enum to enable using DaprClient.invokeMethod() with PATCH requests through HTTPEndpoints

Test plan

  • SDK compiles successfully
  • Verify PATCH method works with invokeMethod() for HTTPEndpoint service invocation

Fixes #1622

@lindner lindner requested review from a team as code owners January 21, 2026 17:21
Adds PATCH to the HttpMethods enum to enable using DaprClient.invokeMethod()
with PATCH requests through HTTPEndpoints. This is commonly required for
partial updates when calling external REST APIs via Dapr service invocation.

Fixes dapr#1622

Signed-off-by: Paul Lindner <plindner@metropolis.io>
@lindner lindner force-pushed the add-patch-http-method branch from c703f67 to 443b03d Compare January 21, 2026 17:22
@salaboy
Copy link
Collaborator

salaboy commented Jan 21, 2026

@lindner thanks for the contribution. We will definitely need a test for this. I would recommend you an integration test too using test container to validate that the change works using the sidecar.

@lindner
Copy link
Author

lindner commented Jan 29, 2026

@lindner thanks for the contribution. We will definitely need a test for this. I would recommend you an integration test too using test container to validate that the change works using the sidecar.

Can you help me identify the correct place for this? It's just another HTTP verb, so I don't think it's going to need much...

@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.99%. Comparing base (fd16fe2) to head (ce4b3c7).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1623      +/-   ##
============================================
+ Coverage     78.97%   78.99%   +0.01%     
+ Complexity     2097     2096       -1     
============================================
  Files           228      228              
  Lines          6321     6322       +1     
  Branches        693      693              
============================================
+ Hits           4992     4994       +2     
+ Misses          978      976       -2     
- Partials        351      352       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@salaboy
Copy link
Collaborator

salaboy commented Jan 30, 2026

Copy link
Collaborator

@salaboy salaboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is great but we need tests, one test here will be enough: https://github.com/dapr/java-sdk/blob/master/sdk/src/test/java/io/dapr/client/DaprHttpTest.java#L247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add PATCH to HttpMethods enum for service invocation

2 participants