[Earning and Spending]: Update link and remove broken link to dashnew… also RIP two introduction/information.rst #520
Conversation
…s.org Also removed some broken links from introduction/information.rst
WalkthroughDocumentation updates in two RST files: revised links and wording in earning/spending guidance, overhauled merchant discovery instructions, updated debit card disclaimers and removed Bitwala section; and pruned two entries from the News list. No code changes or API impacts. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Noticed that a URL changed, so I just also updated that. |
Thanks for the contribution! Which paragraphs are you referring to that should be updated? |
The Discover Dash site is dead. We should remove that paragraph, add something like https://cryptwerk.com/pay-with/dash/ and any other useful merchant directory, if any, and say something like "To find businesses that accept Dash, you can check out one of the following online merchant directories:". The Dash app also has a feature to find merchants, right? Maybe mention that as well. |
Site only mentions btc, etc, usdc
|
I suggested some changes to incorporate: jorgesumle#1 |
docs: earning-spending updates
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (8)
docs/user/earning-spending.rst (8)
29-30: Verify link titles/permalinks; consider canonical capitalization.Please confirm these two blog URLs are still live and that the link texts match the posts’ canonical titles. If titles changed, prefer the canonical capitalization; otherwise keep our house style consistent.
Run a link check locally (see linkcheck script below) and update casing if needed.
42-44: Add at least one third‑party merchant directory and clarify app support.Given Discover Dash is gone, consider listing multiple directories to avoid single‑point link rot and rephrase the app line to be platform‑agnostic. Suggested edit:
-To find businesses that accept Dash, check out `Where to Spend Dash <https://www.dash.org/spend/>`_. -The Dash mobile apps also include a built-in merchant finder feature to help you locate nearby -businesses that accept Dash payments. +To find businesses that accept Dash, see: + +- `Where to Spend Dash <https://www.dash.org/spend/>`_ +- `Cryptwerk — Pay with Dash <https://cryptwerk.com/pay-with/dash/>`_ + +Note: Dash mobile apps include a merchant‑finder feature; availability and coverage may vary by region.Please confirm Cryptwerk’s Dash page remains current before adding.
52-52: Minor wording polish.Tighten phrasing slightly.
-cards are supported. The Dash is either exchanged at the time of -purchase or in advance. +cards are supported. Dash is exchanged either at the time of purchase +or in advance.
58-58: Broaden the caveat on card availability/features.Expand to set expectations and reduce support burden.
-availability of Dash debit cards. +availability and features of Dash‑compatible debit cards, including fees, +limits, and supported regions.
60-63: Use correct entity name and add non‑endorsement language.“Dash Core” should be “Dash Core Group” and we should add a neutral non‑endorsement clause.
-Disclaimer: This list is provided for informational purposes only. Dash -Core is not liable for any funds transmitted in error to these -providers, or for the accuracy of information on this page. +Disclaimer: This list is provided for informational purposes only. Dash +Core Group does not endorse any provider listed here and is not liable +for any funds transmitted in error to these providers, or for the +accuracy of information on this page.Please confirm with comms/legal that “Dash Core Group” is the intended entity reference for these docs.
64-116: Alt text for images to improve accessibility.Add alt text to the card logos for screen readers.
-.. image:: img/crypto.png +.. image:: img/crypto.png + :alt: Crypto.com logo ... -.. image:: img/change.png +.. image:: img/change.png + :alt: Change Invest logo ... -.. image:: img/spectrocoin.png +.. image:: img/spectrocoin.png + :alt: SpectroCoin logo
72-76: Time‑sensitive copy (“over 40 million merchants globally”).Numbers change and can become inaccurate. Prefer evergreen phrasing.
- over 40 million merchants globally. + merchants worldwide.
113-116: Avoid “soon”; use neutral, dated language.“potentially available again soon” will age poorly.
- physical card potentially available again soon. + physical card availability varies by region; check current status.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/user/earning-spending.rst(2 hunks)docs/user/introduction/information.rst(0 hunks)
💤 Files with no reviewable changes (1)
- docs/user/introduction/information.rst
🔇 Additional comments (3)
docs/user/earning-spending.rst (3)
40-40: LGTM: clearer global scope.“physical locations worldwide.” reads better and is accurate.
42-116: Sanity‑check: providers currently list DASH — confirm regional card availability before publishing.
- Crypto.com — DASH listed; issues prepaid Visa/Mastercard‑style cards in many regions; card/asset access varies by country — consult Crypto.com’s country/card‑availability / restricted‑markets pages.
- Change (changeinvest.com) — DASH supported; offers a Visa debit/prepaid card for European users.
- SpectroCoin — DASH supported; offers crypto‑linked Visa cards (virtual & physical); issuance/delivery limited to EEA.
- Bitwage and Uphold blogs — live as of September 16, 2025.
1-128: Automate link validation in CI (Sphinx linkcheck).Add a CI job that installs Sphinx (or uses docs/requirements.txt) and runs the Sphinx linkcheck builder, failing the job if any broken links are found — ensure docs/requirements.txt exists and Sphinx is available (the earlier run failed due to a missing docs/requirements.txt and no sphinx-build). Example CI script:
#!/bin/bash set -euo pipefail # Install docs deps if present, otherwise ensure Sphinx is installed if [ -f docs/requirements.txt ]; then python -m pip install -r docs/requirements.txt else python -m pip install --upgrade sphinx fi # Run linkcheck python -m sphinx -b linkcheck docs _build/linkcheck # Fail on any reported broken links if grep -n -i 'broken' _build/linkcheck/output.txt >/dev/null 2>&1; then echo "Broken links found:" grep -n -i 'broken' _build/linkcheck/output.txt exit 1 fi echo "No broken links found."
2 participants
There are more links from the Earning and Spending page that should also be removed, but the paragraphs that contain them should be updated. I didn't do that. Maybe we can debate what to write there instead.
Preview build: https://dash-docs--520.org.readthedocs.build/en/520/
Summary by CodeRabbit