Skip to content

Only set signal handler in runners #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacobtomlinson merged 2 commits into from
Dec 19, 2025
Merged

Only set signal handler in runners #697

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bf64fc
Only set signal handler in runners
jacobtomlinson Dec 19, 2025
ce67324
Reduce indirection
jacobtomlinson Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions dask_jobqueue/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,6 @@
from distributed.worker import Worker


# Close gracefully when receiving a SIGINT
# We use SIGINT to shut down because the scheduler and worker hang
# if we call sys.exit() see https://github.com/dask/distributed/issues/8644
if threading.current_thread() is threading.main_thread():
signal.signal(signal.SIGINT, lambda *_: sys.exit())


class Role(Enum):
"""
This Enum contains the various roles processes can be.
Expand Down Expand Up @@ -68,6 +61,11 @@ def __init__(
asynchronous: bool = False,
loop: asyncio.BaseEventLoop = None,
):
# Close gracefully when receiving a SIGINT
# We use SIGINT to shut down because the scheduler and worker hang
# if we call sys.exit() see https://github.com/dask/distributed/issues/8644
if threading.current_thread() is threading.main_thread():
signal.signal(signal.SIGINT, lambda *_: sys.exit())
self.status = Status.created
self.scheduler = scheduler
self.scheduler_address = None
Expand Down
Loading