-
Notifications
You must be signed in to change notification settings - Fork 29
Bump cdap and hadoop version #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@itsankit-google i am not confident on the |
| public static final TestConfiguration CONFIG = | ||
| new TestConfiguration(Constants.Explore.EXPLORE_ENABLED, false, | ||
| Constants.AppFabric.SPARK_COMPAT, Compat.SPARK_COMPAT); | ||
| new TestConfiguration(EXPLORE_ENABLED, false, Constants.AppFabric.SPARK_COMPAT, Compat.SPARK_COMPAT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try removing this config altogether?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
java.lang.NoClassDefFoundError usually means dependency conflicts needs to be resolved at pom level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
itsankit-google
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add build.yml & build-report.yml files?
ref: https://github.com/data-integrations/salesforce/tree/develop/.github/workflows
892ad8b to
83fceba
Compare
83fceba to
9836388
Compare
pom.xml
Outdated
| <hadoop.version>3.3.6</hadoop.version> | ||
| <httpcomponents.version>4.5.9</httpcomponents.version> | ||
| <hydrator.version>2.10.0-SNAPSHOT</hydrator.version> | ||
| <hydrator.version>2.10.0</hydrator.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump it to 2.13.0-SNAPSHOT for consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumped 👍
d6a8aba to
f86effa
Compare
|
The unit tests failing here are also failing in |
Build with unit tests is a required step to pass when we bump any dependencies. We need to make sure it is green before proceeding with any other change. |
f86effa to
b8bd3bf
Compare
b8bd3bf to
7f7e8c1
Compare
|
🥳 Unit Tests Fixed |


Bump cdap and hadoop version ( Unit Test Fixes )
Bump up CDAP (
6.11.0-SNAPSHOT) and Hadoop (3.3.6) version for error management.Unit Tests Fixed
HttpSourceETLTest.javaHttpStreamingSourceETLTest.javaHTTPSinkTest.javaOther changes
slf4j-reload4jEXPLORE_ENABLEDSanity Check on new build