PLUGIN-1940 : Support Array Type #132
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from ServiceNowColumn
| try { | ||
| if (results == null) { | ||
| fetchData(); | ||
| fetchData(false); |
Contributor
There was a problem hiding this comment.
why is this false always
|
|
||
| private void fetchData() throws ServiceNowAPIException { | ||
| private void fetchData(Boolean enableNewDataTypes) throws ServiceNowAPIException { | ||
| this.enableNewDataTypes = enableNewDataTypes; |
Contributor
There was a problem hiding this comment.
where are we using this
| for (Schema.Field field : tableFields) { | ||
| String fieldName = field.getName(); | ||
| ServiceNowRecordConverter.convertToValue(fieldName, field.getSchema(), row, recordBuilder); | ||
| ServiceNowRecordConverter.convertToValue(fieldName, field.getSchema(), row, recordBuilder, |
Contributor
There was a problem hiding this comment.
is this passed by DTS separately because everytime it seems like it is false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLUGIN-1940
This change introduces support for mapping ServiceNow
glide_listfields to BigQueryARRAY<STRING>types in the ServiceNow CDAP plugin.New Flag added:
enableNewDataTypesIf this flag is true, then the fields with
glide_listtype are mapped to Array of Strings in BigQuery, otherwise, it is mapped to StringNote: There was no option to specify base type while defining List as the type of a column in ServiceNow.