Skip to content

Conversation

@goanpeca
Copy link
Collaborator

@goanpeca goanpeca commented Jul 17, 2025

fixes #52

Add pre-commit to check code style and format, and adds a workflow to check it as well. Added dependabot workflow to keep actions up to date.

@goanpeca goanpeca force-pushed the enh/pre-commit branch 2 times, most recently from 41f91b2 to dbb3843 Compare July 17, 2025 02:17
@goanpeca goanpeca marked this pull request as ready for review July 17, 2025 02:19
@goanpeca goanpeca requested a review from echarles July 17, 2025 02:20
@goanpeca goanpeca changed the title Add precommit Add pre-commit Jul 17, 2025
@goanpeca goanpeca self-assigned this Jul 17, 2025
@echarles
Copy link
Member

@goanpeca This one has conflicts further to the merge of #51

@goanpeca goanpeca force-pushed the enh/pre-commit branch 2 times, most recently from a923455 to a351c78 Compare July 17, 2025 09:19
@echarles
Copy link
Member

@goanpeca Just refactored the jupyter api, will open a PR for that asap

Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thx @goanpeca

@echarles echarles merged commit 7455e04 into datalayer:main Jul 17, 2025
5 of 17 checks passed
@goanpeca goanpeca deleted the enh/pre-commit branch July 17, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add pre-commit to the repo to have a standard code format

2 participants