Add shared entry batch actions in collections navigation #3334
Conversation
|
📦 Statoscope quick diff with main-branch: ⏱ Build time: -660 ms (-1.2%) ⚖️ Initial size: 0.56 kb (0.01%) 🕵️ Validation errors: 0 Full Statoscope report could be found here |
|
|
|
| deleteCollectionsPromise, | ||
| deleteWorkbooksPromise, | ||
| deleteSharedEntriesPromise, | ||
| ]).then((response) => { |
There was a problem hiding this comment.
A few notes on this part of the code:
Promise.alldoesn't handle exceptions. If one of the promises throws an error, the whole thing will fail because you haven't defined a catch block. If you don't care about the errors, you should usePromise.allSettledinstead.- Style-wise, it's better to use either callback syntax or async/await. In your case, you should store the
Promise.allresult in a variable and await the resolution of the promises.
Are there any plans to display errors for entities that failed to be deleted in the future?
| ); | ||
| } | ||
|
|
||
| await Promise.all([moveCollectionsPromise, moveWorkbooksPromise, moveEntriesPromise]); |
There was a problem hiding this comment.
The same question like for handleDelete action
No description provided.