Support gravity-charts in ChartAlert #3345

korvin89 · 2025-12-25T15:17:10Z

No description provided.

github-actions · 2025-12-25T15:20:47Z

📦 Statoscope quick diff with main-branch:

⏱ Build time: 154 ms (0.28%)

⚖️ Initial size: 0.00 kb (0%)

🕵️ Validation errors: 0

Full Statoscope report could be found here ↗️

github-actions · 2025-12-25T15:23:19Z

E2E Tests No Auth

Playwright test results

206 passed
13 flaky
2 skipped

Details

221 tests across 118 suites
3 minutes, 37 seconds
ba75c94

Flaky tests

opensource › opensource-suites/dash/revisions/revisionsListWithCreationDashboards.test.ts › Dashboards - Versioning › Creating a dashboard, editing, saving as a draft, making the draft version relevant
opensource › opensource-suites/dash/screenshots/baseWidgets.test.ts › Dashboards - Base widgets screenshots › Widgets without autoheight @screenshot
opensource › opensource-suites/dash/screenshots/markdownCases.test.ts › Dashboards - Markdown cases screenshots › Tab with different markdown widgets @screenshot
opensource › opensource-suites/dash/screenshots/widgetsBackground.test.ts › Dashboards - widgets backgrounds screenshots › Chart bg color @screenshot
opensource › opensource-suites/dash/selectors/global/baseActions.test.ts › Dashboards - Global selectors with impact type base actions › Creating a global selector with "All Tabs" impact type - selector appears on all tabs
opensource › opensource-suites/dash/selectors/global/baseActions.test.ts › Dashboards - Global selectors with impact type base actions › Creating a global selector with "Selected Tabs" impact type - selector appears only on selected tabs
opensource › opensource-suites/dash/selectors/global/baseActions.test.ts › Dashboards - Global selectors with impact type base actions › Editing global selector - changing from "All Tabs" to "Selected Tabs" updates visibility
opensource › opensource-suites/dash/selectors/global/baseActions.test.ts › Dashboards - Global selectors with impact type base actions › Multiple selectors with different impact types coexist correctly
opensource › opensource-suites/wizard/fields/parameters.test.ts › Wizard › Fields › Renaming should not affect the operation of the parameter
opensource › opensource-suites/wizard/visualizations/flat-table/coloring.test.ts › Wizard › Flat table › Empty values - ignore nulls @screenshot
opensource › opensource-suites/wizard/visualizations/flat-table/linear-indicator.test.ts › Wizard › Flat table › Linear indicator with column background color @screenshot
opensource › opensource-suites/wizard/visualizations/pivot-table/totals.test.ts › Wizard › Pivot table › Subtotals for NULL values
opensource › opensource-suites/wizard/visualizations/scatter/axis-settings.test.ts › Wizard › Scatter chart › Min and max values for Y-axis @screenshot

Skipped tests

opensource › opensource-suites/dash/revisions/revisionsList.test.ts › Dashboards - Versioning › Dashboard with a long list of revisions, checking the upload and the updated list of revisions
opensource › opensource-suites/dash/selectors/autoupdateRelatedSelectors.test.ts › Dashboards - Autoupdate options of group selectors › Manual selectors with aliases don't affect each other before applying when auto-update is disabled

🧐 Links with traces:

👉 Link with detailed report: report

🐳 Link with docker compose logs: logs

Last updated: 2025-12-27 02:01:28 MSK

github-actions · 2025-12-25T15:23:22Z

E2E Tests

Playwright test results

206 passed
13 flaky
2 skipped

Details

221 tests across 118 suites
3 minutes, 36 seconds
ba75c94

Flaky tests

opensource › opensource-suites/connections/postgres.test.ts › Postgres connector interactions › Client validation errors should be displayed after creation attempt
opensource › opensource-suites/connections/ytsaurus.test.ts › YTsaurus connector interactions › Connector should be created
opensource › opensource-suites/dash/revisions/revisionsListWithCreationDashboards.test.ts › Dashboards - Versioning › Creating a dashboard, editing, saving as a draft, making the draft version relevant
opensource › opensource-suites/dash/screenshots/widgetsBackground.test.ts › Dashboards - widgets backgrounds screenshots › Title bg color @screenshot
opensource › opensource-suites/dash/selectors/global/baseActions.test.ts › Dashboards - Global selectors with impact type base actions › Creating a global selector with "All Tabs" impact type - selector appears on all tabs
opensource › opensource-suites/dash/selectors/global/baseActions.test.ts › Dashboards - Global selectors with impact type base actions › Creating a global selector with "Selected Tabs" impact type - selector appears only on selected tabs
opensource › opensource-suites/dash/selectors/global/baseActions.test.ts › Dashboards - Global selectors with impact type base actions › Editing global selector - changing from "All Tabs" to "Selected Tabs" updates visibility
opensource › opensource-suites/dash/selectors/global/baseActions.test.ts › Dashboards - Global selectors with impact type base actions › Multiple selectors with different impact types coexist correctly
opensource › opensource-suites/wizard/filters/filters-with-dialog-color.test.ts › Wizard filters › Two or more values of the Date field from the dashboard filter section should use IN operation by default
opensource › opensource-suites/wizard/visualizations/flat-table/formatting.test.ts › Wizard › Flat table › Old date format
opensource › opensource-suites/wizard/visualizations/flat-table/preview.test.ts › Wizard › Flat table › Event "chart-preview.done" is triggered for table with no data
opensource › opensource-suites/wizard/visualizations/pivot-table/totals.test.ts › Wizard › Pivot table › Subtotals for Rows @screenshot
opensource › opensource-suites/wizard/visualizations/scatter/coloring.test.ts › Wizard › Scatter chart › Point color set by the fake title of the field @screenshot

Skipped tests

opensource › opensource-suites/dash/revisions/revisionsList.test.ts › Dashboards - Versioning › Dashboard with a long list of revisions, checking the upload and the updated list of revisions
opensource › opensource-suites/dash/selectors/autoupdateRelatedSelectors.test.ts › Dashboards - Autoupdate options of group selectors › Manual selectors with aliases don't affect each other before applying when auto-update is disabled

🧐 Links with traces:

👉 Link with detailed report: report

🐳 Link with docker compose logs: logs

Last updated: 2025-12-27 02:00:36 MSK

github-actions · 2025-12-25T15:24:46Z

E2E Tests Farm

Playwright test results

414 passed
11 flaky
1 skipped

Details

426 tests across 171 suites
4 minutes, 40 seconds
ba75c94

Flaky tests

basic › suites/charts/export/forbiddenExport.test.ts › Chart export availability › Wizard with forbidden export › Export menu item is disabled if export is forbidden on dataset
basic › suites/charts/export/forbiddenExport.test.ts › Chart export availability › Preview with forbidden export › Wizard preview - Export menu item is disabled if export is forbidden on connection
basic › suites/charts/export/forbiddenExport.test.ts › Chart export availability › Preview with forbidden export › Wizard preview - Export menu item is disabled if export is forbidden on dataset
basic › suites/charts/export/forbiddenExport.test.ts › Chart export availability › Preview with forbidden export › Ql preview - Export menu item is disabled if export is forbidden on connection
basic › suites/charts/export/forbiddenExport.test.ts › Chart export availability › Ql - Export menu item is disabled if export is forbidden on connection
basic › suites/dash/widgets/autoheight.test.ts › Dashboards - Auto-height of widgets › When switching to another widget tab with auto-height, it adjusts without scrolling
basic › suites/dataset/parameters/parameterDialogValidation.test.ts › Datasets - Parameter dialog validation › Required fields validation
basic › suites/dataset/parameters/parameterDialogValidation.test.ts › Datasets - Parameter dialog validation › Parameter name validation
basic › suites/dataset/parameters/parameterDialogValidation.test.ts › Datasets - Parameter dialog validation › Parameter default_value validation [number]
basic › suites/wizard/colors/coloredByMeasureNames.test.ts › Wizard - section "Colors" › Multidatasets. Fields with the same name should be automatically colored in different colors
basic › suites/wizard/metric/metricCustomization.test.ts › Wizard - metric chart. Settings › Size change

Skipped tests

basic › suites/wizard/combined-chart/layers-and-multidatasets.test.ts › Multi-faceted charts with layers › The data on the X-axis must be formed correctly from two datasets

👉 Link with detailed report: report

Last updated: 2025-12-27 02:05:16 MSK

kuzmadom · 2025-12-29T09:18:51Z

src/ui/components/Widgets/Chart/utils-chart-alert.ts

+        return false;
+    }
+
+    return Boolean(get(value, 'data.series.data'));


it is better to check by the entry type

github-actions bot added changelog component/general type/deps labels Dec 25, 2025

korvin89 requested a review from kuzmadom December 25, 2025 15:31

korvin89 force-pushed the CHARTS-12329-support-gravity-charts-in-alerts-dialog branch from 207f4e0 to 58a47de Compare December 26, 2025 22:07

korvin89 changed the title ~~Add enrichLoadedData to ChartAlert component & up @gravity-ui/chartkit 7.30.0 -> 7.31.1~~ Support gravity-charts in ChartAlert Dec 26, 2025

Evgeny Alaev added 2 commits December 27, 2025 01:25

Support gravity-charts in ChartAlert

435a1ba

fix args defining

c9df34d

korvin89 force-pushed the CHARTS-12329-support-gravity-charts-in-alerts-dialog branch from 5dd684a to c9df34d Compare December 26, 2025 22:25

Fix alarm padding

ba75c94

kuzmadom reviewed Dec 29, 2025

View reviewed changes

kuzmadom approved these changes Dec 29, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Support gravity-charts in ChartAlert #3345

Support gravity-charts in ChartAlert #3345

Uh oh!

korvin89 commented Dec 25, 2025

Uh oh!

github-actions bot commented Dec 25, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 25, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 25, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 25, 2025 •

edited

Loading

Uh oh!

kuzmadom Dec 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Support gravity-charts in ChartAlert #3345

Are you sure you want to change the base?

Support gravity-charts in ChartAlert #3345

Uh oh!

Conversation

korvin89 commented Dec 25, 2025

Uh oh!

github-actions bot commented Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Tests No Auth

Playwright test results

Details

Uh oh!

github-actions bot commented Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Tests

Playwright test results

Details

Uh oh!

github-actions bot commented Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Tests Farm

Playwright test results

Details

Uh oh!

kuzmadom Dec 29, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Dec 25, 2025 •

edited

Loading

github-actions bot commented Dec 25, 2025 •

edited

Loading

github-actions bot commented Dec 25, 2025 •

edited

Loading

github-actions bot commented Dec 25, 2025 •

edited

Loading