Removed remaining duplicate valueName parameters #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed duplicate 'valueName' attributes from all remaining Policy nodes where child Policy Element nodes also have a 'valueName' attribute defined and both values are equal (example: both have an attribute of valueName="foo"). The valueName attribute on the Policy node specifies the registry value to check to determine whether the policy is "Disabled" (0), "Enabled" (non-zero), or "Not Configured" (missing). A non-numeric value here will cause the policy to be evaluated as "Not Configured". The valueName attribute on the Policy Element nodes specifies the registry value where the user's selections should be stored. When the valueName for the Policy and Policy Element nodes are set to the same value, it results in unexpected behavior in certain cases. For example, an enum with a decimal value of 0 would cause the policy to be evaluated as "Disabled" or a text value (non-numeric) will cause the policy to be evaluated as "Not Configured" even though the expected value may be present in the registry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed duplicate 'valueName' attributes from all remaining Policy nodes where child Policy Element nodes also have a 'valueName' attribute defined and both values are equal (example: both have an attribute of valueName="foo").
The valueName attribute on the Policy node specifies the registry value to check to determine whether the policy is "Disabled" (0), "Enabled" (non-zero), or "Not Configured" (missing). A non-numeric value here will cause the policy to be evaluated as "Not Configured".
The valueName attribute on the Policy Element nodes specifies the registry value where the user's selections should be stored.
When the valueName for the Policy and Policy Element nodes are set to the same value, it results in unexpected behavior in certain cases. For example, an enum with a decimal value of 0 would cause the policy to be evaluated as "Disabled" or a text value (non-numeric) will cause the policy to be evaluated as "Not Configured" even though the expected value may be present in the registry.