'Offset' and 'length' arguments added to fincore method #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmap call begins at offset bytes and maps length bytes. Offset defaults to zero (start of file). A length of 0 will mmap the entire file minus the offset value. Length also defaults to zero, therefore, the behavior should stay the same for any legacy users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mmap call begins at offset bytes and maps length bytes. Offset defaults
to zero (start of file). A length of 0 will mmap the entire file minus
the offset value. Length also defaults to zero, therefore, the behavior
should stay the same for any legacy users.
This makes this the fincore method much more usable for large files - parts of the file can be queried piece-wise to improve responsiveness.