Fixed: Code readability (spaces, code comments) and segregate repetitive tags to individual components #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nconsistencies. Added explanatory comments for callout code.
|
@Tazmenian is attempting to deploy a commit to the shelly_boy's projects Team on Vercel. A member of the Team first needs to authorize it. |
davidrayc
approved these changes
Mar 19, 2024
evad-e
requested changes
Mar 19, 2024
app/components/ProductModal.tsx
Outdated
| </div> | ||
| <div className="flex justify-between mt-4"> | ||
| <label htmlFor="itemCode" className="block mb-1">Item Code</label> | ||
| <input |
Collaborator
There was a problem hiding this comment.
Input is repetitive. Please separate in another component
app/components/ProductModal.tsx
Outdated
| /> | ||
| </div> | ||
| <div className="flex justify-end w-full mt-6"> | ||
| <button |
Collaborator
There was a problem hiding this comment.
Buttons are repetitive as well. Please put in a separate component
| import { useEffect, useState } from 'react'; | ||
| import Login from '../app/components/Login'; | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
Please format. Remove added spaces
Collaborator
|
Update PR title as well please |
…ive tags to individual components
Tazmenian
changed the title
evad-e
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Just added below codes for Product Modal
-have updated latest devDepencies at package.jason
-include useeffect on page.tsx for calling of product modal
-added color light-green on tailwind config