-
Notifications
You must be signed in to change notification settings - Fork 8
Update to work with the latest crates #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| Ok(Firebase { | ||
| url: Arc::new(url), | ||
| }) | ||
| Firebase::from_url(url) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this refactor 👍
|
Hi @panicbit thanks for the PR! |
|
I decided to switch to |
|
It is because |
|
I'm not using Windows primarily but AFAIK setting up native dependencies is a pain. |
|
Oh so we shouldn't depend on |
|
I'm not saying that you shouldn't, but I guess it would be nice to gradually move towards pure Rust crates. Hyper sadly still has a dependency on |
|
You're right that pure rust crates are ideal, I'll think about it and get back to you. |
| let opts = vec![ (AUTH, auth_token) ]; | ||
| url.set_query_from_pairs(opts.into_iter()); | ||
| let mut url = try!(Url::parse(&url)); | ||
| url.query_pairs_mut().append_pair(AUTH, auth_token).finish(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good too!
|
I cannot build this. |
|
For my own crate, I've switched to using |
This change is