Fix unnecessary/restrictive public target flags #3126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3125, where building dlib using one compiler or system and linking to a consumer using a different one is incompatible.
Key changes:
target_compile_optionsandtarget_compile_featuresfromPUBLICtoPRIVATE, preventing dlib's compile-time configuration forcing incorrect assumptions on the consumer.active_compile_optsdlib_needed_public_cflags(now nameddlib_needed_private_cflags)dlib_needed_public_ldflags(now nameddlib_needed_private_ldflags)active_compile_optsandactive_compile_opts_private(the latter no longer needs to be a separate variable)active_compile_optsno longer requires different methodologies depending on if MSVC + CMake < 3.11 are used (simpler approach)