Support images field in initial params and hide prompt interp controls #358
+117
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yondon Fu <yondon.fu@gmail.com>
Signed-off-by: Yondon Fu <yondon.fu@gmail.com>
Signed-off-by: Yondon Fu <yondon.fu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
imagesfield in initial paramsFYI @ryanontheinside constrained maxImages to 1 for the Reference Images component because multiple ref images can be accepted in the backend right now, but doesn't actually do anything so to avoid confusion only allowing 1 image in the ImageManager right now until the user can expect multiple images to actually have an effect.
The thinking behind the chnages to hide prompt interpolation controls is to use the smallest possible diff that does not clash with the desire to move away from supports* fields and towards declaring parameters in schema and having their existence signal support without requiring a separate supports* field.
🤖 Generated with Claude Code