feat: implement plugable map combined with event emitter #403
Conversation
packages/plugable/src/plugable.ts
Outdated
| @@ -0,0 +1,96 @@ | |||
| import { type Plugable, type Key, internals, PlugableInternals, Val } from './types'; | |||
|
|
|||
| const proto = { | |||
There was a problem hiding this comment.
maybe inline the functions on the proto instead of proxy them?
also set the Plugable type.
| set(parent, key, 'hello'); | ||
|
|
||
| expect(res[0]).to.equal('hello'); | ||
| }); |
There was a problem hiding this comment.
missing tests:
- inherited record doesn't effect the origin
- call return value of
on()to stop listening - listen with multiple listeners (check that removing 1 doesn't change the others)
| }); | ||
| }); | ||
|
|
||
| describe('Plugable (prototype api)', () => { |
There was a problem hiding this comment.
what is this test for? seems like you test the API in the previous tests.
There was a problem hiding this comment.
This is related all the other tests checking the non prototype api.
at this point I'm not sure which one is preferred WDYT?
* use getThrow * improve set default value perf
* add more tests * expose createKey on the api
daomry
left a comment
daomry
left a comment
There was a problem hiding this comment.
How about some docs, examples etc? see other packages in the repo for the formatting
daomry
left a comment
daomry
left a comment
There was a problem hiding this comment.
please add ts-docs comments to functions you export, this is used to generate the docs
This is very wordy but I didn't get what's it's used for. can you plz explain? |
No description provided.