Better keyword_casing=auto heuristic.
#1473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider both the first and last letter of the user's text when choosing case for completion candidates when keyword_casing=auto. The issue is that when the last character typed is non-alphabetic such as underscore, then islower() is False. Better to check both the first and last character of the user's text. If either of them is lowercase then we complete with lowercase.
rolandwalker
force-pushed
the
RW/better-auto-casing-heuristic
branch
from
efc1c29 to
8407a30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Consider both the first and last letter of the user's text when choosing case for completion candidates when keyword_casing=auto.
The issue is that when the last character typed is non-alphabetic such as underscore, then
islower()is False. Better to check both the first and last character of the user's text. If either of them is lowercase then we complete with lowercase.Fixes #1462 .
Checklist
changelog.md.AUTHORSfile (or it's already there).uv run ruff check && uv run ruff format && uv run mypy --install-types .to lint and format the code.