Let favorite queries be special commands #1477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottnemes
reviewed
Jan 24, 2026
| if is_special: | ||
| for result in special_execute(cur, sql): | ||
| result.title = title | ||
| yield result |
Contributor
There was a problem hiding this comment.
Works great! Only suggestion would be adding a comment here to highlight that the special_execute function returns a SQLResult, so that is why it's just yielding the "result" var instead of a SQLResult object like the rest of the yields. Will approve as-is so feel free to add it or not
scottnemes
approved these changes
Jan 24, 2026
rolandwalker
force-pushed
the
RW/let-favorites-be-special-commands
branch
from
d8deb1c to
b5fefc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #747 .
Checklist
changelog.md.AUTHORSfile (or it's already there).uv run ruff check && uv run ruff format && uv run mypy --install-types .to lint and format the code.