Simplify binary value rendering #1478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by upgrading cli_helpers to v2.8.1. The previous version of cli_helpers attempted to UTF-8 decode binary values, leading to treating some values differently than others.
scottnemes
approved these changes
Jan 24, 2026
Contributor
scottnemes
left a comment
scottnemes
left a comment
There was a problem hiding this comment.
Not able to repro the original issue, but an upgrade is good in my book either way.
Contributor
Author
|
I actually had second thoughts and reverted the underlying change here dbcli/cli_helpers#99 on the theory that it could affect redis-cli or similar. We can make the change configurable in the application instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplify binary value rendering by upgrading
cli_helpersto v2.8.1. The previous version ofcli_helpersattempted to UTF-8 decode binary values, leading to treating some values differently than others.Fixes #1010.
xref dbcli/cli_helpers#98
Checklist
changelog.md.AUTHORSfile (or it's already there).uv run ruff check && uv run ruff format && uv run mypy --install-types .to lint and format the code.