Better solution for binary value rendering #1483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After dbcli/cli_helpers#100 we can use the new convert_to_undecoded_string preprocessor to guarantee that binary values are rendered as hex literals. It would be neat if in a future PR we added an option to _never_ render binaries as hex literals (but just emit their contents). The align_decimals preprocessor would seem to have no effect and should be removed in a separate commit. The bugfix here is covered under the existing changelog entry.
scottnemes
approved these changes
Jan 26, 2026
Contributor
scottnemes
left a comment
scottnemes
left a comment
There was a problem hiding this comment.
Still can't repro, but everything seems to work fine so looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After dbcli/cli_helpers#100 we can use the new
convert_to_undecoded_stringpreprocessor to guarantee that binary values are rendered as hex literals.It would be neat if in a future PR we added an option to never render binaries as hex literals (but just emit their contents).
The
align_decimalspreprocessor would seem to have no effect and should be removed in a separate commit.The bugfix here is covered under the existing changelog entry.
Fixes #1010 .
Checklist
changelog.md.AUTHORSfile (or it's already there).uv run ruff check && uv run ruff format && uv run mypy --install-types .to lint and format the code.