Refactor completions for special commands #1487
Merged
+30
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottnemes
approved these changes
Jan 28, 2026
rolandwalker
force-pushed
the
RW/refactor-special-completions
branch
from
b2f0b12 to
c68c7f3
Compare
* read SPECIAL_COMMANDS from special.main instead of hardcoding, moving the hardcoding needed for tests to the test suite * move use/connect to suggest_special() alongside their backslash aliases * move tableformat to suggest_special() alongside its backslash alias, * move redirectformat to suggest_special() alongside its backslash alias * complete "source" even if the keyword is uppercase * commentary
rolandwalker
force-pushed
the
RW/refactor-special-completions
branch
from
c68c7f3 to
77d7ab8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SPECIAL_COMMANDSfromspecial.maininstead of hardcoding, moving the hardcoding needed for tests to the test suiteuse/connecttosuggest_special()alongside their backslash aliasestableformattosuggest_special()alongside its backslash alias,redirectformattosuggest_special()alongside its backslash aliassourceeven if the keyword is uppercaseChecklist
changelog.md.AUTHORSfile (or it's already there).uv run ruff check && uv run ruff format && uv run mypy --install-types .to lint and format the code.