Added zlib compression and fixed shard error 1003 on startup #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented zlib compression support. However, the current logging behavior is not fully understood — log messages may not appear correctly. This may be due to the logging process occurring before decompression, and relocating it post-decompression could potentially resolve the issue.
Additionally, an issue was identified where a shard would throw error 1003 on startup and immediately reboot. This was resolved by deferring the execution using futureTick().
This commit does not resolve the underlying issue with mass shard reboots. However, while working on it, I inadvertently introduced a mistake that caused a "ZLIB decompression error" during shard restarts. Unexpectedly, this led to the shard rebooting cleanly and without system load, which resembled the intended behavior. Although this was not an intentional change and is unrelated to the actual modifications, the behavior observed in the logic executed after this error may point to the correct direction and should be taken into account in future debugging efforts.