Drop bluebird/co, switch to async function #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
This should also close #9 |
|
@ddsol Is there an issue with the PR? It's quite useful! :) |
|
music-metadata supports promises (async / await) & TypeScript definitions out of the box. |
|
Tried a copy-paste of the PR and it seems to work perfectly. Merging this should be a no-brainer in a normal world. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Async functions are directly supported by NodeJS for quite a while. It's time to drop bluebird and and co.
Tests and CI configuration have been updated, and
.d.tstype declaration file has been created too.