Fixing overlap of Assembly Name and Command/Commandgroup #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pace would block out those commands if you didn't specify the assembly name they were in. Now if the command being looked for isn't found in the assembly go back to look across all the commands without specifying an assembly. In future, potentially should handle the commands being overloaded in this case but this is a fairly rare case only brought up due to killfeed prefixing its commands with killfeed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The plugin Killfeed had it's commands start with killfeed this clashed with the assembly name also being killfeed which meant you need to use for example
.killfeed killfeed. This is due to if there was a match at the start with an assembly name it wouldn't fallback in the case of no match to checking all commands with no assembly name specified.Solution
If we don't find a match in the assembly specified then do a search over all commands.
Notes
In future, potentially should handle the commands being overloaded in this case but this is a fairly rare case only brought up due to killfeed prefixing its commands with killfeed. Not likely that there is overlap of
.assemblyName commandwith some plugin's.commandgroup commandwhere commandgroup = assemblyname