Skip to content

Return empty string on success callback #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thmzlt wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Return empty string on success callback #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c549d4
Add test to catch empty string resp bug
Jul 18, 2014
6e92dba
Fix empty string resp bug
Jul 18, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/reqwest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@
} catch (e) {
// can't assign this in IE<=8, just ignore
}
if (r) {
if (r || r == '') {
switch (type) {
case 'json':
try {
Expand Down
Empty file added tests/fixtures/empty.html
View file
Open in desktop
Empty file.
10 changes: 10 additions & 0 deletions tests/tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,16 @@
})
})

test('empty resp string is passed to callback', function (complete) {
ajax({
url: '/tests/fixtures/empty.html'
, success: function (resp) {
ok(resp == '', 'resp object isn\'t empty string')
complete()
}
})
})

test('invalid JSON sets error on resp object', function (complete) {
ajax({
url: '/tests/fixtures/invalidJSON.json'
Expand Down