-
-
Notifications
You must be signed in to change notification settings - Fork 42
Added Owntracks friend data support, including avatar and location data. #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce `OwntracksIngestionApiController` to handle Owntracks data. - Add friend data response support with avatars and location. - Clean up unused dependencies in `TimelineController`. - Rename and refactor `IngestApiController` to `OverlandIngestionApiController`.
…elated tests - Remove `OwntracksIngestApiController` and `OwntracksIngestApiControllerIntegrationTest`. - Refactor friend data response with optimized avatar processing in `OwntracksIngestionApiController`. - Update test and package organization to improve structure. - Extend Redis cache configuration for avatar thumbnails.
…mocking and service methods
- Replace redundant mocking with cleaner service methods. - Simplify `userSharingJdbcService` and `rawLocationPointJdbcService` calls. - Remove unused imports and assertions. - Enhance code readability and maintainability.
…ControllerIntegrationTest - Update test to expect `isOk` instead of `isBadRequest`.
- Refactor `TimelineController` to support friend timeline data aggregation. - Improve date range processing with finer role-based access control. - Replace `LocalDate` methods with `ZoneId` and `Instant` for timezone handling. - Streamline services (`UserJdbcService`, `UserSharingJdbcService`, `TimelineService`, etc.). - Upgrade `thumbnailator` dependency to `0.4.21`. - Remove deprecated methods and unused imports to simplify code.
- Add logging for thumbnail generation errors in `AvatarService`. - Update image resources in integration tests to use more descriptive files. - Mark `AvatarData` and `AvatarInfo` as `Serializable`.
- Delete redundant test scenarios for Owntracks ingestion without/with elevation. - Remove test for Owntracks non-location message handling.
|
Just tested it in version 3.1 and it works beautifully! Thanks for this nice feature addition 🚀 ❤️ |
Contributor
Author
Yeah, that one brought me so much joy when developing it. It was an awesome feature request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This pull request introduces several enhancements and fixes, including:
AvatarService Improvements:
Integration Tests and Refactoring:
AvatarServiceandOwntracksIngestionController.OwntracksIngestApiControllerand optimized friend data response handling.Timeline and Owntracks Data Enhancements:
TimelineControllerfor aggregation of friend timeline data and improved role-based access control.Dependency Updates:
thumbnailatorlibrary and removed unused imports for cleaner code.