Skip to content

Conversation

@dgraf-gh
Copy link
Contributor

@dgraf-gh dgraf-gh commented Jan 3, 2026

Description of Changes

This pull request introduces several enhancements and fixes, including:

  • AvatarService Improvements:

    • Added logging for thumbnail generation errors.
    • Updated integration tests to use real image resources for better accuracy.
    • Enhanced caching for avatar data retrieval by user ID and added cache eviction methods for updates.
    • Introduced a cached thumbnail method with optimized image processing.
  • Integration Tests and Refactoring:

    • Added comprehensive integration tests for AvatarService and OwntracksIngestionController.
    • Simplified and streamlined related service methods and test assertions.
    • Removed deprecated OwntracksIngestApiController and optimized friend data response handling.
  • Timeline and Owntracks Data Enhancements:

    • Refactored TimelineController for aggregation of friend timeline data and improved role-based access control.
    • Added Owntracks ingestion API with friend data support, including avatar and location data.
  • Dependency Updates:

    • Upgraded thumbnailator library and removed unused imports for cleaner code.

- Introduce `OwntracksIngestionApiController` to handle Owntracks data.
- Add friend data response support with avatars and location.
- Clean up unused dependencies in `TimelineController`.
- Rename and refactor `IngestApiController` to `OverlandIngestionApiController`.
…elated tests

- Remove `OwntracksIngestApiController` and `OwntracksIngestApiControllerIntegrationTest`.
- Refactor friend data response with optimized avatar processing in `OwntracksIngestionApiController`.
- Update test and package organization to improve structure.
- Extend Redis cache configuration for avatar thumbnails.
- Replace redundant mocking with cleaner service methods.
- Simplify `userSharingJdbcService` and `rawLocationPointJdbcService` calls.
- Remove unused imports and assertions.
- Enhance code readability and maintainability.
…ControllerIntegrationTest

- Update test to expect `isOk` instead of `isBadRequest`.
- Refactor `TimelineController` to support friend timeline data aggregation.
- Improve date range processing with finer role-based access control.
- Replace `LocalDate` methods with `ZoneId` and `Instant` for timezone handling.
- Streamline services (`UserJdbcService`, `UserSharingJdbcService`, `TimelineService`, etc.).
- Upgrade `thumbnailator` dependency to `0.4.21`.
- Remove deprecated methods and unused imports to simplify code.
- Add logging for thumbnail generation errors in `AvatarService`.
- Update image resources in integration tests to use more descriptive files.
- Mark `AvatarData` and `AvatarInfo` as `Serializable`.
@dgraf-gh dgraf-gh linked an issue Jan 3, 2026 that may be closed by this pull request
@dgraf-gh dgraf-gh added the enhancement New feature or request label Jan 3, 2026
- Delete redundant test scenarios for Owntracks ingestion without/with elevation.
- Remove test for Owntracks non-location message handling.
@dgraf-gh dgraf-gh merged commit d267b09 into main Jan 3, 2026
3 checks passed
@dgraf-gh dgraf-gh deleted the 588-feature-request-owntracks-friends-support branch January 3, 2026 08:47
@tobru
Copy link

tobru commented Jan 5, 2026

Just tested it in version 3.1 and it works beautifully! Thanks for this nice feature addition 🚀 ❤️

@dgraf-gh
Copy link
Contributor Author

dgraf-gh commented Jan 5, 2026

Just tested it in version 3.1 and it works beautifully! Thanks for this nice feature addition 🚀 ❤️

Yeah, that one brought me so much joy when developing it. It was an awesome feature request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] OwnTracks Friends Support

3 participants