Auto Login When Token is Present #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .travis.yml # src/api.py # src/jobs.py # src/login.py # src/uix/config.py # test/steps/step_api.py # test/test_api.py
…LUTO into sgomena/develop
# Conflicts: # .travis.yml # src/integrationtest/python/features/login.feature # src/integrationtest/python/steps/step_login.py # src/main.py # src/main/python/api.py # src/main/python/login.py # src/main/python/resources.py # src/uix/config.py # test/test_api.py
…a/develop # Conflicts: # src/main/python/app.py # src/main/python/jobs.py
logyball
previously approved these changes
Oct 1, 2019
Contributor
logyball
left a comment
logyball
left a comment
There was a problem hiding this comment.
Scenario: Verify only email input hint # src/integrationtest/python/features/login.feature:21
When I spin up the application # src/integrationtest/python/steps/step_helpers.py:39 0.046s
And I open the login window # src/integrationtest/python/steps/step_login.py:13 0.000s
And I enter "test_user@test_email.com" in the username input box # src/integrationtest/python/steps/step_login.py:28 0.000s
And I click the login button # src/integrationtest/python/steps/step_login.py:48 0.001s
Then the login hint text should be "Please enter your password." # src/integrationtest/python/steps/step_login.py:55 0.000s
Assertion Failed: 'Please enter your email and password.' does not equal 'Please enter your password.'
Scenario: Verify only password input hint # src/integrationtest/python/features/login.feature:28
When I spin up the application # src/integrationtest/python/steps/step_helpers.py:39 0.051s
And I open the login window # src/integrationtest/python/steps/step_login.py:13 0.000s
And I enter "test_password" in the password input box # src/integrationtest/python/steps/step_login.py:28 0.000s
And I click the login button # src/integrationtest/python/steps/step_login.py:48 0.001s
Then the login hint text should be "Please enter your email." # src/integrationtest/python/steps/step_login.py:55 0.000s
Assertion Failed: 'Please enter your email and password.' does not equal 'Please enter your email.'
Scenario: Verify incorrect credentials hint # src/integrationtest/python/features/login.feature:35
When I spin up the application # src/integrationtest/python/steps/step_helpers.py:39 0.051s
And I open the login window # src/integrationtest/python/steps/step_login.py:13 0.000s
And I enter "test_user@test_email.com" in the username input box # src/integrationtest/python/steps/step_login.py:28 0.000s
And I enter "test_password" in the password input box # src/integrationtest/python/steps/step_login.py:28 0.000s
And I click the login button # src/integrationtest/python/steps/step_login.py:48 0.001s
Then the login hint text should be "The email or password you entered is not recognized." # src/integrationtest/python/steps/step_login.py:55 0.000s
Assertion Failed: 'Please enter your email and password.' does not equal 'The email or password you entered is not recognized.'
Scenario: Verify correct credentials hint # src/integrationtest/python/features/login.feature:43
When I spin up the application # src/integrationtest/python/steps/step_helpers.py:39 0.050s
And I open the login window # src/integrationtest/python/steps/step_login.py:13 0.000s
And I enter "samgomena@gmail.com" in the username input box # src/integrationtest/python/steps/step_login.py:28 0.000s
And I enter "password" in the password input box # src/integrationtest/python/steps/step_login.py:28 0.000s
And I click the login button # src/integrationtest/python/steps/step_login.py:48 0.001s
Then I should be able to log in to the application # src/integrationtest/python/steps/step_login.py:62 0.000s
Assertion Failed: '0' does not equal '1'
some issues locally with the behave tests but I think the fixes should be in the fbs_refactor branch
added 5 commits
October 1, 2019 21:23
# Conflicts: # Pipfile.lock
Contributor
|
is this ready for re-review? Can probably merge develop back into it and put it up for review again |
Member
Author
Alright, sorry for letting the file modification count balloon into the dozens but this should be ready to for another look over and I think the majority of the changes should be pretty straight forward! |
…xt; remove token on __exit__.
…rror on fallthrough.
…n window functionality.
logyball
approved these changes
Nov 6, 2019
Contributor
logyball
left a comment
logyball
left a comment
There was a problem hiding this comment.
just one minor thing - removing the token from src
logyball
reviewed
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add functionality for:
I realize this functionality isn't crucial but it was maddening to do any serious testing/development on the app and have to login every time.
Also, this already has Martin's changes incorporated so PR #67 should go in first!Note: This functionality requires a new version of the API to be running which will be deployed sometime within the next week.