fix: avoid IndexError in BF16_Optimizer.destroy() when using DummyOptim #7763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi @leejianwoo-collab, thank you for your contribution! |
Contributor
Author
|
ok @tohtana |
Collaborator
|
@leejianwoo-collab thanks for the PR. For context, |
sfc-gh-truwase
approved these changes
Jan 6, 2026
leejianwoo-collab
added a commit
to leejianwoo-collab/DeepSpeed_woo
that referenced
this pull request
Jan 7, 2026
…im (deepspeedai#7763) fix: avoid IndexError in BF16_Optimizer.destroy() when using DummyOptim Short-circuit BF16_Optimizer.destroy() if using_real_optimizer is False. When initialized with optimizer=None (DummyOptim), bf16_groups remains empty, causing an IndexError when accessing it in destroy(). Resolves deepspeedai#7752 Signed-off-by: leejianwoo-collab <leejianwoo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: avoid IndexError in BF16_Optimizer.destroy() when using DummyOptim
Short-circuit BF16_Optimizer.destroy() if using_real_optimizer is False.
When initialized with optimizer=None (DummyOptim), bf16_groups remains empty, causing an IndexError when accessing it in destroy().
Resolves #7752