Fix Gradle 9 deprecations #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
A pull request to address Gradle 9 deprecations by switching to a supported Java plugin extension and updating the configuration for the main class in both native image configuration and the application manifest.
- Updated nativeimage.gradle to use mainClass.set() with a hardcoded value.
- Revised build.gradle to remove deprecated mainClassName property and update the application configuration and manifest accordingly.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cake/lwjgl3/nativeimage.gradle | Updated mainClass assignment to use the .set() method with a hardcoded launcher name. |
| cake/lwjgl3/build.gradle | Converted mainClass configuration to use a variable and updated the manifest attributes accordingly. |
| main { | ||
| imageName = appName | ||
| mainClass = project.mainClassName | ||
| mainClass.set('org.demoth.cake.lwjgl3.Lwjgl3GameLauncher') |
There was a problem hiding this comment.
[nitpick] Consider externalizing the main class name to a shared configuration or variable to ensure consistency with the build.gradle settings, which can help reduce duplication across files.
Suggested change
| mainClass.set('org.demoth.cake.lwjgl3.Lwjgl3GameLauncher') | |
| mainClass.set(mainClassName) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
javaplugin extension instead of deprecatedJavaPluginConventionmainClassNameproperty and update manifest/native image configTesting
./gradlew help --warning-mode allhttps://chatgpt.com/codex/tasks/task_e_6848a11b54208329ad9e06152981c463