Refactor code #13
Open
Refactor code #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split up the code across 3 files: opts - argument parsing lib - main procfd logic main - renders results
mkomitee
reviewed
Jan 14, 2026
mkomitee
left a comment
mkomitee
left a comment
There was a problem hiding this comment.
This is a very difficult review because it appears as though it's a complete re-write except for the main function.
I know it isn't, but it's very tedious to verify that there are no changes included, so instead I'll just ask, have you been careful to ensure that there are no unrelated changes in here, and it's all a matter of re-organizing existing code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split up the code across 3 files:
opts - argument parsing
lib - main procfd logic
main - renders results