Skip to content

Conversation

@abarciauskas-bgse
Copy link
Contributor

This PR removes:

  • the datacube-benchmark package (see more notes on this below)
  • API references for the datacube-benchmark package
  • Notebooks describing the methodology for and reporting on TiTiler-CMR benchmarking and compatibility

The visualization section of the documentation is looking a little sparse and TiTiler-focused. Should we add content about the other methods of visualization (direct client libraries, python libraries) or at least link to that content in the Zarr Visualization Report?

datacube-benchmark package

This package contains both utilities for benchmarking TiTiler-CMR (datacube_benchmark.titiler) as well as more general-purpose synthetic datacube generation + testing utilities (datacube_benchmark.*). The former I think belongs in the TiTiler-CMR repo. The latter looks very useful! But I'm not sure where/when they were used. It seems like this code could be in another repo and then used for more general purpose datacube/zarr store benchmarking against various APIs?

@maxrjones
Copy link
Member

thanks @abarciauskas-bgse! I agree with the CMR specific components going into the Titiler-CMR repository. However, the general tools were used for demonstrating the impact of the "worst practices" defined in the guide (e.g., https://developmentseed.org/datacube-guide/worst-practices/tiny-chunks.html#demonstrating-storage-inefficiencies-of-too-small-of-chunks). Could you please leave those and only remove the titiler specific components?

@abarciauskas-bgse
Copy link
Contributor Author

abarciauskas-bgse commented Dec 12, 2025 via email

@abarciauskas-bgse
Copy link
Contributor Author

@maxrjones after adding back the datacube_benchmark package (minus the titiler subdirectory) I tried to run some of the notebooks using the instructions in the README, i.e.:

uv run ipython kernel install --user --env VIRTUAL_ENV $(pwd)/.venv --name=project
uv run --with jupyter jupyter lab

but noticed these notebooks depend on some zarr stores in Azure, for which I got the following error:

Screenshot 2025-12-12 at 2 15 41 PM

Do you think we could make these stores public?

@maxrjones
Copy link
Member

@maxrjones after adding back the datacube_benchmark package (minus the titiler subdirectory) I tried to run some of the notebooks using the instructions in the README, i.e.:

uv run ipython kernel install --user --env VIRTUAL_ENV $(pwd)/.venv --name=project
uv run --with jupyter jupyter lab

but noticed these notebooks depend on some zarr stores in Azure, for which I got the following error:

Screenshot 2025-12-12 at 2 15 41 PM Do you think we could make these stores public?

Thanks for pointing this out. I'll address this separately.

@maxrjones maxrjones merged commit 3397ad7 into main Dec 14, 2025
2 checks passed
@maxrjones maxrjones deleted the remove-titiler-cmr-benchmarking branch December 14, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants