feat: Add forwarding of X-Forwarded-Port. #112
Closed
+67
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTTP X-Forwarded-Host (XFH) request header is an official but de-facto standard and not clearly defining when it comes to the way ports are indicated. It seems both of these approaches are common:
X-Forwarded-Host: example.com:80X-Forwarded-Host: example.comwithX-Forwarded-Port: 80The second seems to be more common among ingress proxy solutions for kubernetes (nginx and traefik).
The first approach with
X-Forwarded-Host: example.com:80is already supported by stac-auth-proxy. This PR adds support forX-Forwarded-Portheader. If stac-auth-proxy receives it, to just forward it to the upstream STAC API.