feat: [WIP] Add support for geoarrow point layers #241
Conversation
✅ Deploy Preview ready!
|
gadomski
left a comment
gadomski
left a comment
There was a problem hiding this comment.
In general, looks about right! Just one refactor on how we're passing information, and one thing I'm not sure about the upstream.
src/utils/stac-geoparquet.ts
Outdated
| const points = io.parseWkb(data, io.WKBType.Point, 2); | ||
| table = new Table({ | ||
| // @ts-expect-error: 2769 | ||
| geometry: makeVector(points), |
There was a problem hiding this comment.
I'm not sure this works for points, we might have to update the upstream dependency ... I could be wrong, though.
stac-map-pr-241-zoom-bug.mov@gadomski here is what this currently looks like for the points geometry type. I've been testing with parquet files from here. But I cant figure out the bug where when I zoom in - the points disappear? Would you happen to know how to fix that or what is going on there? i've tried different things but i'm not familiar enough. Also related to #242 - I've left a comment there after taking a look 👍🏼 |
| getFillColor: fillColor, | ||
| getPosition: table.getChild("geometry")!, | ||
| getLineColor: lineColor, | ||
| getLineWidth: 2, | ||
| opacity: 1, | ||
| radiusMinPixels: 0.5, |
There was a problem hiding this comment.
Try this on for size:
| getFillColor: fillColor, | |
| getPosition: table.getChild("geometry")!, | |
| getLineColor: lineColor, | |
| getLineWidth: 2, | |
| opacity: 1, | |
| radiusMinPixels: 0.5, | |
| getColor: lineColor, | |
| getRadius: 2, | |
| getPosition: table.getChild("geometry")!, | |
| radiusUnits: "pixels", |
Ticket: #179
Checklist
yarn format)yarn lint)yarn build)yarn test)