Feature/admin forth/1137/lets remove heavy debug and in #445

yaroslav8765 · 2026-01-09T12:14:43Z

No description provided.

…ector, and socketBroker modules

…cross components

Copilot

Pull request overview

This PR modernizes the logging infrastructure by replacing scattered console.log, console.error, and environment-based debug statements with a structured logging system using pino and pino-pretty. The implementation introduces three logger instances (logger, afLogger, dbLogger) for different logging contexts, each configurable via environment variables.

Changes:

Introduced centralized logging module using pino with three distinct loggers for user logs, AdminForth internal logs, and database query logs
Replaced console.log/console.error and process.env.HEAVY_DEBUG && console.log() patterns with appropriate logger calls throughout the codebase
Added pino and pino-pretty dependencies to package.json
Updated documentation and templates to use the new logger

Reviewed changes

Copilot reviewed 37 out of 38 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
adminforth/modules/logger.ts	New centralized logging module with three logger instances
adminforth/package.json	Added pino and pino-pretty dependencies
adminforth/servers/express.ts	Replaced console.log with afLogger calls
adminforth/modules/socketBroker.ts	Converted debug logs to afLogger.trace
adminforth/modules/restApi.ts	Replaced console.log with afLogger calls
adminforth/modules/codeInjector.ts	Converted debug and info logs to afLogger
adminforth/index.ts	Exported logger and replaced console.log with afLogger
adminforth/dataConnectors/*.ts	Replaced database debug logs with dbLogger
dev-demo/resources/*.ts	Updated to use logger from adminforth
dev-demo/index.ts	Replaced console.log with logger calls
adminforth/spa/src/components/*.vue	Removed commented-out console.log statements
adminforth/documentation/*/.md	Updated examples to use logger
adminforth/commands/*/.js	Replaced console.log with afLogger calls

Files not reviewed (1)

adminforth/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-10T12:57:11Z

adminforth/commands/postinstall.js

-    console.log('SPA dependencies not found');
-    console.log('current directory', import.meta.dirname);
+    afLogger.warn('SPA dependencies not found');
+    afLogger.info('current directory', import.meta.dirname);


Using afLogger.warn instead of console.log for 'SPA dependencies not found' is correct, but the following line should also use afLogger.warn or afLogger.info instead of afLogger.info for 'current directory' since it's related to the same warning context.

Suggested change

afLogger.info('current directory', import.meta.dirname);

afLogger.warn('current directory', import.meta.dirname);

Copilot · 2026-01-10T12:57:12Z

adminforth/modules/logger.ts

@@ -0,0 +1,29 @@
+import pino from 'pino';
+import { PinoPretty } from "pino-pretty";


The import statement 'import { PinoPretty } from "pino-pretty"' is importing a type that is not being used in the code. This import should be removed as PinoPretty is never referenced in the file.

Suggested change

import { PinoPretty } from "pino-pretty";

Copilot · 2026-01-10T12:57:12Z

adminforth/servers/express.ts

      }
      this.expressApp.get(`${slashedPrefix}assets/*`, handler);
-      process.env.HEAVY_DEBUG && console.log('®️ Registering SPA serve handler', `${slashedPrefix}assets/*`);
+      afLogger.trace(`®️ Registering SPA serve handler', ${slashedPrefix}assets/*`);


The afLogger.trace call has a mismatched quote character - it starts with a backtick but contains a single quote in the middle: '®️ Registering SPA serve handler', ${slashedPrefix}assets/*. This should use consistent template literal syntax throughout.

Copilot · 2026-01-10T12:57:12Z

adminforth/dataConnectors/postgres.ts

            await this.client.connect();
            this.client.on('error', async (err) => {
-                console.log('Postgres error: ', err.message, err.stack)
+                afLogger.error(`Postgres error: ${err.message} ${err.stack}`);


The PostgreSQL connector is using afLogger.error for error logging, but should be using the dbLogger for database-related errors to maintain consistent logging layers. The error handling code at line 20 should use dbLogger.error instead.

Suggested change

afLogger.error(`Postgres error: ${err.message} ${err.stack}`);

dbLogger.error(`Postgres error: ${err.message} ${err.stack}`);

Copilot · 2026-01-10T12:57:12Z

adminforth/index.ts

    // execute hook if needed
    for (const hook of listify(resource.hooks?.create?.beforeSave)) {
-      console.log('🪲 Hook beforeSave', hook);
+      console.debug('🪲 Hook beforeSave', hook);


The console.debug call should be replaced with logger.debug for consistency with the rest of the logging changes in this PR.

Suggested change

console.debug('🪲 Hook beforeSave', hook);

afLogger.debug('🪲 Hook beforeSave', hook);

Copilot · 2026-01-10T12:57:13Z

adminforth/dataConnectors/mongo.ts

+                    afLogger.error(`Mongo error: ${err.message}`);
                });
-                console.log('Connected to Mongo');
+                afLogger.info('Connected to Mongo');
            } catch (e) {
-                console.error(`Failed to connect to Mongo: ${e}`);
+                afLogger.error(`Failed to connect to Mongo: ${e}`);


MongoDB error logging is using afLogger for database connection errors. For consistency, these should use dbLogger instead, similar to the other database connectors. This applies to lines 39, 41, and 43.

Copilot · 2026-01-10T12:57:14Z

adminforth/modules/codeInjector.ts

        }
      });
      devServer.stderr.on('data', (data) => {
        console.error(`[AdminForth SPA ERROR]:`);


The console.error call should be replaced with afLogger.error for consistency with the rest of the logging changes in this PR.

Suggested change

console.error(`[AdminForth SPA ERROR]:`);

afLogger.error(`[AdminForth SPA ERROR]:`);

Copilot · 2026-01-10T12:57:14Z

adminforth/commands/createApp/templates/adminuser.ts.hbs

@@ -1,5 +1,5 @@
 import AdminForth, { AdminForthDataTypes } from 'adminforth';
-import type { AdminForthResourceInput, AdminForthResource, AdminUser } from 'adminforth';
+import type { AdminForthResourceInput, AdminForthResource, AdminUser, logger } from 'adminforth';


In the template file, the import statement is importing 'logger' as a type from 'adminforth', but logger is not a type - it's a value/export. The import should be: import { Filters, logger } from 'adminforth'; without the 'type' keyword before AdminForthResourceInput.

Suggested change

import type { AdminForthResourceInput, AdminForthResource, AdminUser, logger } from 'adminforth';

import type { AdminForthResourceInput, AdminForthResource, AdminUser } from 'adminforth';

import { logger } from 'adminforth';

Copilot · 2026-01-10T12:57:14Z

adminforth/commands/callTsProxy.js

          if (!silent) {
            parsed.capturedLogs.forEach((log) => {
-              console.log(...log);
+              afLogger.log(...log);


The afLogger.log method is being called, but pino loggers don't have a .log() method. This should be changed to an appropriate log level like afLogger.info() or afLogger.debug().

Suggested change

afLogger.log(...log);

const [level, ...args] = log;

if (level && typeof afLogger[level] === "function") {

afLogger[level](...args);

} else {

afLogger.info(...log);

}

Copilot · 2026-01-10T12:57:15Z

adminforth/commands/createCustomComponent/fileGenerator.js

  try {
    await fs.mkdir(customDirPath, { recursive: true });
-    console.log(chalk.dim(`Ensured custom directory exists: ${customDirPath}`));
+    afLogger.warn(chalk.dim(`Ensured custom directory exists: ${customDirPath}`));


The afLogger.warn call should be afLogger.info since this is informational logging about ensuring a directory exists, not a warning condition.

Suggested change

afLogger.warn(chalk.dim(`Ensured custom directory exists: ${customDirPath}`));

afLogger.info(chalk.dim(`Ensured custom directory exists: ${customDirPath}`));

yaroslav8765 added 7 commits January 9, 2026 14:13

feat: add pino logger

11efdf3

chore: update db logs to support pino logger

cc90b21

chore: use logge instead of HEAVY_DEBUG

6b0d3bb

chore: enhance logging messages for clarity in baseConnector, codeInj…

b7b70f6

…ector, and socketBroker modules

fix: correct import path for afLogger in proxy.ts

9541c4d

chore: replace console logging with afLogger for consistent logging a…

7b1718b

…cross components

chore: use logger instead of console.log

c3ae78b

yaroslav8765 requested a review from Copilot January 10, 2026 12:53

Copilot started reviewing on behalf of yaroslav8765 January 10, 2026 12:54 View session

Copilot AI reviewed Jan 10, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature/admin forth/1137/lets remove heavy debug and in #445

Feature/admin forth/1137/lets remove heavy debug and in #445

Uh oh!

yaroslav8765 commented Jan 9, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 10, 2026

Uh oh!

Copilot AI Jan 10, 2026

Uh oh!

Copilot AI Jan 10, 2026

Uh oh!

Copilot AI Jan 10, 2026

Uh oh!

Copilot AI Jan 10, 2026

Uh oh!

Copilot AI Jan 10, 2026

Uh oh!

Copilot AI Jan 10, 2026

Uh oh!

Copilot AI Jan 10, 2026

Uh oh!

Copilot AI Jan 10, 2026

Uh oh!

Copilot AI Jan 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	afLogger.info('current directory', import.meta.dirname);
	afLogger.warn('current directory', import.meta.dirname);

		@@ -0,0 +1,29 @@
		import pino from 'pino';
		import { PinoPretty } from "pino-pretty";

	afLogger.error(`Postgres error: ${err.message} ${err.stack}`);
	dbLogger.error(`Postgres error: ${err.message} ${err.stack}`);

	console.debug('🪲 Hook beforeSave', hook);
	afLogger.debug('🪲 Hook beforeSave', hook);

	console.error(`[AdminForth SPA ERROR]:`);
	afLogger.error(`[AdminForth SPA ERROR]:`);

	import type { AdminForthResourceInput, AdminForthResource, AdminUser, logger } from 'adminforth';
	import type { AdminForthResourceInput, AdminForthResource, AdminUser } from 'adminforth';
	import { logger } from 'adminforth';

-              afLogger.log(...log);
+              const [level, ...args] = log;
+              if (level && typeof afLogger[level] === "function") {
+                afLogger[level](...args);
+              } else {
+                afLogger.info(...log);
+              }

	afLogger.warn(chalk.dim(`Ensured custom directory exists: ${customDirPath}`));
	afLogger.info(chalk.dim(`Ensured custom directory exists: ${customDirPath}`));

Feature/admin forth/1137/lets remove heavy debug and in #445

Are you sure you want to change the base?

Feature/admin forth/1137/lets remove heavy debug and in #445

Uh oh!

Conversation

yaroslav8765 commented Jan 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants