Skip to content

Conversation

@shirayner
Copy link

feat: support customize model name

@qianmoQ
Copy link
Member

qianmoQ commented Dec 20, 2024

@shirayner
Thank you for your contribution. You are required to deal with the style issues of the code before merging.

openai-java-sdk/src/main/java/org/devlive/sdk/openai/OpenAiClient.java:186: Multiple consecutive blank lines [RegexpMultiline]
openai-java-sdk/src/main/java/org/devlive/sdk/openai/entity/ChatEntity.java:102:54: '{' at column 54 should be on a new line. [LeftCurly]
openai-java-sdk/src/main/java/org/devlive/sdk/openai/entity/ChatEntity.java:119:15: 'if' is not followed by whitespace. [WhitespaceAround]
openai-java-sdk/src/main/java/org/devlive/sdk/openai/entity/ChatEntity.java:119:48: '{' is not preceded with whitespace. [WhitespaceAround]
openai-java-sdk/src/main/java/org/devlive/sdk/openai/entity/ChatEntity.java:122:13: '}' at column 13 should be alone on a line. [RightCurly]
openai-java-sdk/src/main/java/org/devlive/sdk/openai/entity/ChatEntity.java:122:14: 'else' is not preceded with whitespace. [WhitespaceAround]

@shirayner
Copy link
Author

I fixed the style error, please help me to approve it

@shirayner shirayner changed the title feat: support customize model name feat: support customize model name #50 Dec 20, 2024
@qianmoQ
Copy link
Member

qianmoQ commented Dec 20, 2024

I fixed the style error, please help me to approve it

openai-java-sdk/src/main/java/org/devlive/sdk/common/DefaultClient.java:83:9: '}' at column 9 should be alone on a line. [RightCurly]
openai-java-sdk/src/main/java/org/devlive/sdk/common/DefaultClient.java:113:9: '}' at column 9 should be alone on a line. [RightCurly]
openai-java-sdk/src/main/java/org/devlive/sdk/common/DefaultClient.java:385:9: '}' at column 9 should be alone on a line. [RightCurly]
openai-java-sdk/src/main/java/org/devlive/sdk/openai/entity/ChatEntity.java:123:13: '}' at column 13 should be alone on a line. [RightCurly]

@shirayner
Copy link
Author

please help me to approve it again

@qianmoQ
Copy link
Member

qianmoQ commented Dec 20, 2024

Thank you for your contribution

@qianmoQ qianmoQ closed this Dec 20, 2024
@qianmoQ qianmoQ reopened this Dec 20, 2024
@qianmoQ qianmoQ merged commit 8c2876f into devlive-community:dev Dec 20, 2024
4 checks passed
@qianmoQ qianmoQ linked an issue Dec 20, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support custom model name

2 participants