feat: configure CMC to play nice with cycles ledger #72
Conversation
Co-authored-by: Eric Swanson <64809312+ericswanson-dfinity@users.noreply.github.com>
| canister_name: "cycles_ledger", | ||
| canister_id: "um5iw-rqaaa-aaaaq-qaaba-cai", | ||
| wasm_name: "cycles_ledger.wasm.gz", | ||
| wasm_url: "https://github.com/dfinity/cycles-ledger/releases/latest/download/cycles-ledger.wasm.gz", |
There was a problem hiding this comment.
This makes builds and tests non-reproducible, if they depend on this extension. It's already a problem that this is the case for II and nns-dapp, above. Do we need to have the same issue with the cycles-ledger?
There was a problem hiding this comment.
I've asked that this issue with II and nns-dapp be corrected in #60
There was a problem hiding this comment.
Fair point. No, this is not needed, and we can make the update script keep this up to date if we ever want the extension to install the cylces ledger
This reverts commit 5a66c6f.
extensions/nns/src/install_nns.rs
Outdated
| .unwrap(), | ||
| ) | ||
| .unwrap(); |
There was a problem hiding this comment.
the unwrap on Encode!() I can go along with, .write_all().unwrap() probably not
There was a problem hiding this comment.
Agreed, and there were more mistakes. I must have dropped the self-review somehow
1 participant
No description provided.