Skip to content

feat: [NODE-1805] Add measurements to repro script #8147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Bownairo merged 4 commits into from
Dec 29, 2025
Merged

feat: [NODE-1805] Add measurements to repro script #8147

Bownairo merged 4 commits into from
Dec 29, 2025

Conversation

@Bownairo
Copy link
Contributor

@Bownairo Bownairo commented Dec 18, 2025

Also brings some minor fixes, and updates the mainnet revisions script to the new dashboard API.

@github-actions github-actions bot added the feat label Dec 18, 2025
Bownairo
Bownairo commented Dec 18, 2025
View reviewed changes
Copy link
Contributor Author

@Bownairo Bownairo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to use -p <proposal id> in the repro instructions for the extra verification, but I understand the chicken-egg situation that puts us in. Could the instructions ask reproducers to grab the proposal ID?

@Bownairo Bownairo force-pushed the eero/repro-measurements branch from 63bd737 to 8b129c2 Compare December 18, 2025 22:57
@Bownairo Bownairo marked this pull request as ready for review December 18, 2025 23:13
@Bownairo Bownairo requested review from a team as code owners December 18, 2025 23:13
@Bownairo Bownairo requested review from a team and frankdavid December 23, 2025 18:05
nmattia
nmattia approved these changes Dec 23, 2025
View reviewed changes
Copy link
Contributor

@nmattia nmattia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp. Merry christmas!

@NikolaMilosa
Copy link
Contributor

NikolaMilosa commented Dec 29, 2025

@Bownairo We could extend automation on our side to generate a different command they would use for running a script. Only downside I see with it:
We can't run those additional tests in CI (we run repro check in CI) - that would mean that green CI no longer means that we are sure that the repro check script works (since it has additional checks which we just cannot check).

Modifying the text that goes at the bottom of the proposal (in IC-OS verification) would be on our plate if we decide to do so.

@Bownairo Bownairo added this pull request to the merge queue Dec 29, 2025
Merged via the queue into master with commit af40c80 Dec 29, 2025
42 checks passed
@Bownairo Bownairo deleted the eero/repro-measurements branch December 29, 2025 19:35
mraszyk pushed a commit that referenced this pull request Jan 5, 2026
@Bownairo @mraszyk
feat: [NODE-1805] Add measurements to repro script (#8147)
8b62867 
Also brings some minor fixes, and updates the mainnet revisions script
to the new dashboard API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NikolaMilosa NikolaMilosa NikolaMilosa approved these changes

@nmattia nmattia nmattia approved these changes

@frankdavid frankdavid Awaiting requested review from frankdavid

Assignees

No one assigned

Labels

@dre feat @idx

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Bownairo @NikolaMilosa @nmattia