chore: replace run_system_test with sh_test #8189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmattia
force-pushed
the
nm-systest-sh-test
branch
2 times, most recently
from
3f56c5c to
49b9726
Compare
nmattia
commented
Dec 23, 2025
This simplifies the system test definition and removes the custom rule. Instead a rule from `rules_shell` is used; the custom rule was just a `sh_test` in disguise.
nmattia
force-pushed
the
nm-systest-sh-test
branch
from
49b9726 to
6ab65e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the system test definition and removes the custom rule. Instead a rule from
rules_shellis used; the custom rule was just ash_testin disguise.