Skip to content

Conversation

@viviveevee
Copy link
Contributor

@viviveevee viviveevee commented Jan 7, 2026

Description

  • Update imports in dfx generate output: index.js and index.d.ts now import @icp-sdk/core instead of @dfinity/.
  • The vite plugin now deduplicates the new package

How Has This Been Tested?

Covered by e2e

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@peterpeterparker
Copy link
Member

LGTM. I quickly tested the resolution of the imports provided in the PR in my IDE, all were resolved. ✅

Cannot tell about the dedupe as I actually never used it but, I guess it's correct.

@viviveevee viviveevee marked this pull request as ready for review January 15, 2026 12:44
@viviveevee viviveevee requested a review from a team as a code owner January 15, 2026 12:44
@lwshang lwshang merged commit 846fdca into master Jan 15, 2026
135 checks passed
@lwshang lwshang deleted the vivee/icp-sdk-core branch January 15, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants