Default invalid colspan/rowspan to size 1 #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hey @kko-harvey thanks for you contribution, the tests are failing, looks like there are more places that get the colspan/rowspan. |
Owner
|
Hey @kko-harvey , could you please fix the tests when possible? Just a kindly reminder. Thanks! |
Owner
|
hey @kko-harvey , could you please fix the tests when possible? Just a kindly reminder. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Seeing from logs that sometimes non int are passed in and it's breaking the entire export. Hopefully this change allows export to goes through.
Issue Reference
Link to the issue this PR addresses, if applicable.
Example: Fixes #123
Checklist Before Requesting a Review