feat: add support for <mark> (highlight) and <ins> (underline) tags #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor HTML-to-DOCX with centralized styles and test coverage
Adds support for two HTML5 semantic elements: 1. <ins> tag - represents inserted text, rendered with underline - Added to FONT_STYLES mapping to 'underline' (same as <u>) 2. <mark> tag - represents highlighted text, rendered with yellow background - Uses w:shd shading element with yellow (#FFFF00) fill color - Consistent with the package's existing background-color mechanism These tags are commonly used in markdown-to-HTML converters and document editing applications.
dfop02
added
New Feature
Owner
|
hey @arthrod , Just a kindly reminder. Thanks! |
Author
|
Anything I can help? |
Owner
@arthrod Yes, I reviewed your PR and there is pending changes, please take a look when had some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
<ins>tag support with underline formatting (same as<u>)<mark>tag support with yellow background highlightBackground
These HTML5 semantic elements are commonly used in:
==highlight==→<mark>)<ins>- InsertionThe
<ins>element represents text that has been added to a document. Per HTML convention, it's typically rendered with underline, same as<u>.Example:
<mark>- HighlightThe
<mark>element represents highlighted text. The default browser style is a yellow background, which this implementation matches.Example:
Changes
constants.py: Added'ins': 'underline'toFONT_STYLESh4d.py: Added handler for<mark>that applies yellow (#FFFF00) background usingw:shdshading element (consistent with existing background-color mechanism)Test plan
<ins>text</ins>renders with underline<mark>text</mark>renders with yellow background<mark><strong>bold highlight</strong></mark>)<mark>can override the default yellow