feat: add option to open datasets in maps-app [CLIM-155] #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
🚀 Deployed on https://pr-90.climate-app.netlify.dhis2.org |
BRaimbault
changed the title
BRaimbault
commented
Nov 24, 2025
Collaborator
Author
BRaimbault
left a comment
BRaimbault
left a comment
There was a problem hiding this comment.
Ready for review.
BRaimbault
force-pushed
the
feat/gee-layers-in-maps-app
branch
from
3351923 to
a3f94f7
Compare
turban
reviewed
Nov 25, 2025
Contributor
turban
left a comment
turban
left a comment
There was a problem hiding this comment.
Looks good, just suggesting some minor changes.
https://dhis2.atlassian.net/browse/CLIM-17 In this PR, the import page has been restructured and the UX improved: * The data element list is populated based on the selected period type. This happens by fetching all the data sets and filtering based on the selected period type, resulting in a list of data elements for the period type. The app ignores if a data element has been added to 2 or more data sets having different period types. It is up to the implementation properly structure the metadata. The setup guide should help admins avoid this situation, but we can't guarantee this. * The instructions on the side have been removed, and instead, the import form includes the needed info directly in the form. * Visual styling improvements * The period type selector is placed above other selections because it influences what data elements are available in the data element selector. * If it is relevant to either know or select the time zone (e.g. hourly data), then it is displayed. * The setup guide now recommends including the selected period type in the code of the data element (for autofilling the data element to import into dhis2). * An import preview summary has been added to inform the user of what is being imported. * Unit tests have been added to demonstrate support for non gregorian calendars * Date validation based on date range for a dataset. It will inform the user if a date is selected that is outside of the range.
BRaimbault
changed the base branch from
main
to
feat/release-import-page-and-enacts
|
jenniferarnesen
force-pushed
the
feat/release-import-page-and-enacts
branch
3 times, most recently
from
9392f34 to
d456729
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements CLIM-155
Requires: dhis2/maps-app#3599
@dhis2/app-service-datastoredependency to handle sharing EE Layer as analytical object via user datastore.DataStoreProviderto exploreTabs.OpenAsMapButtoncomponent (shared, in case we want to also use in import).useUserLocalehook to check user locale (used in importPeriodandOpenAsMapButton).useAppVersionhook to check maps-app version is compatible.OpenAsMapButtonin explore:Elevation,HeatDaily,HeatMonthly,Landcover,PrecipitationDaily,PrecipitationMonthly,TemperatureDaily,TemperatureMonthlyandVegetation.