chore: invalidate getProjectRoleQueryKey #146
Conversation
| queryClient.invalidateQueries({ | ||
| queryKey: getProjectRoleQueryKey({ projectId }), | ||
| }) |
There was a problem hiding this comment.
This shouldn't be needed as it should already be happening due to the invalidation call right above this due to invalidation cascade. Can you confirm if this actually fixes anything? I'd be surprised if it changes anything.
There was a problem hiding this comment.
If your correct, then it could be a race condition where the query has been invalidated, but its serving the stale value while its refetching, and that stale value is triggering the listener to navigate to the "removed bottom sheet". I can try suspending the navigation action while it is being refetched to see if that will solve this issue
There was a problem hiding this comment.
As a sanity check for myself, here's what should be happening based on the relevant react query docs:
- The query key path you're targeting here is:
root/projects/<projectId>/role - The invalidation happening above what you added is invalidating:
root/projects
Since the path in (1) is a subpath of the path in (2), the invalidation should be happening.
There was a problem hiding this comment.
I added this refetch check:
The problem is still happening. So I don't think its a race condition
The next step I will try is to package this pr as a tarball and try it out
There was a problem hiding this comment.
OK, i packaged this fix, and used it in mobile and it did NOT solve the issue
|
For posterity, I tried three fixes:
And the problem still existed in all 3 scenarios |
toward #1597
Invaidates the members role query after they get invited. If they were previously blocked, we want to invalidate the cache so that it shows that the new role after they have been invited