Refactor package structure to com.digitalpetri.util.byteops #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem(s) was I solving?
The package structure was flat, with all classes in
com.digitalpetri.util. This made it unclear which module each class belonged to and didn't follow Java conventions for library organization.What user-facing changes did I ship?
Breaking Change: Package names have been updated across all modules:
com.digitalpetri.utilcom.digitalpetri.util.byteopscom.digitalpetri.utilcom.digitalpetri.util.byteops.nettycom.digitalpetri.utilcom.digitalpetri.util.byteops.unsignedUsers will need to update their import statements when upgrading.
How I implemented it
AbstractByteOpsTestpublic so it can be extended from test classes in other modulesHow to verify it
Manual Testing
mvn clean test)Description for the changelog
Reorganize package structure to
com.digitalpetri.util.byteopswith module-specific subpackages (netty,unsigned). This is a breaking change requiring import updates.