Asserting matrix shapes for Matrix::abs_diff_eq
#1568
Merged
+24
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Wouldn't it make more sense to return |
Contributor
Author
|
@Ralith I also think so that returning false instead of panicking would be a nicer behavior. But for consistency I stayed with panicking. Should we use panicking in this mr and create a followup case to discuss switching from panicking to returning boolean false for all relevant functions? |
Collaborator
|
That makes sense to me! |
Ralith
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1566 .
The method
Matrix::abs_diff_eqdid not assert the matrix shapes before comparing entries via the zipped iterator loop. The shape assertion is done viaassert!()as done in similar functions, e.g.Matrix::relative_eq.Added tests for one standard usage case as well as non-matching shapes (asserting the panic).